Skip to content

fix(ts): xtrim threshold accepts string #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v5
Choose a base branch
from
Open

fix(ts): xtrim threshold accepts string #2828

wants to merge 2 commits into from

Conversation

Eomm
Copy link

@Eomm Eomm commented Sep 5, 2024 •
edited
Loading

Description

The XTRIM command accepts a streamId that is a string:

XTRIM foo MINID "1725522294258-0"

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@leibale
Copy link
Contributor

leibale commented Sep 19, 2024

Good catch! Can you please do it for the v5 branch instead? Thanks!

@Eomm Eomm changed the base branch from master to v5 December 2, 2024 15:44
@nkaradzhov
Copy link
Collaborator

Hi @Eomm, if you are still up to it, we can resurrect this PR and finish it

@Eomm
Copy link
Author

Eomm commented Aug 5, 2025

Hi @Eomm, if you are still up to it, we can resurrect this PR and finish it

I will try to recreate it by EOD 👍🏼

@Eomm Eomm marked this pull request as ready for review August 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eomm @leibale @nkaradzhov